Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > diff --git a/tests/py/ip/masquerade.t b/tests/py/ip/masquerade.t
> > index 26c3704316ae..41f0e98aa6fb 100644
> > --- a/tests/py/ip/masquerade.t
> > +++ b/tests/py/ip/masquerade.t
> > @@ -27,4 +27,4 @@ ip saddr 10.1.1.1 masquerade drop;fail
> > # masquerade with sets
> > tcp dport { 1,2,3,4,5,6,7,8,101,202,303,1001,2002,3003} masquerade;ok
> > ip daddr 10.0.0.0-10.2.3.4 udp dport 53 counter masquerade;ok
> > -iifname eth0 ct state new,established tcp dport vmap {22 : drop, 222 : drop } masquerade;ok
> > +iifname eth0 ct state new,established tcp dport vmap {22 : drop, 222 : drop } masquerade;ok;iifname "eth0" ct state established,new tcp dport vmap {22 : drop, 222 : drop } masquerade
>
> It would be good if before you push this, you remove the assymetry.
>
> I mean, in general, these assymetries in printing should only be used
> to catch things that we have no other choice. In this case I think
> it's just the ct state ordering in flags.
Quotes for iifname and ordering, yes. I can change this to
iifname "eth0" ct state established,new tcp dport vmap {22 : drop, 222 : drop } masquerade;ok
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
