Re: [nf-next PATCH] net: nftables: Respect hash set backend features

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

On Wed, Mar 21, 2018 at 12:34:53PM +0100, Pablo Neira Ayuso wrote:
[...]
> This is clashing with existing fixes in nf.git.

Crap! :)

TBH, I never know which kernel to test against. Candidates usually are
nf-next, nf, net-next and sometimes even net. Probably business as
usual, or do you have a suggestion as to what I should "default" to?
Maybe I should allow for alternative kernels in my testing VM also.

> I think the backend selection needs a rework, this is the idea:
> 
> 1) Register all set_ops in one single list (instead of the _type thing).
> 2) Iterate over the list of _ops, select the one that fits better.
> 
> The idea is to remove the _type, and expose all _ops to the set
> backend selection. So we don't need this workarounds on the select_ops
> code specifically.
> 
> I would suggest a patch on top of what we have in nf.git (but that
> would go for nf-next.git, I telling this because nf-next.git still
> doesn't have the fixes that Florian made for this).

OK, I'll have a look.

Thanks, Phil
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux