On 19 March 2018 at 18:19, Yang Zheng <tomsun.0.7@xxxxxxxxx> wrote:
> nft-ct-helper-{add,get,del}: add, get, or delete ct helper objects from the specified table.
>
It would be great if you extend a bit the commit message with your tests:
% ./nft-ct-helper-get <args>
<nothing>
% ./nft-ct-helper-add <args>
% ./nft-ct-helper-get <args>
[...]
% ./nft-ct-helper-del <args>
% ./nft-ct-helper-get <args>
<nothing>
So other people know about the expected results when running this.
> Signed-off-by: Yang Zheng <tomsun.0.7@xxxxxxxxx>
> ---
> examples/Makefile.am | 14 +++-
> examples/nft-ct-helper-add.c | 149 ++++++++++++++++++++++++++++++++++++++++++
> examples/nft-ct-helper-del.c | 124 +++++++++++++++++++++++++++++++++++
> examples/nft-ct-helper-get.c | 150 +++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 436 insertions(+), 1 deletion(-)
> create mode 100644 examples/nft-ct-helper-add.c
> create mode 100644 examples/nft-ct-helper-del.c
> create mode 100644 examples/nft-ct-helper-get.c
>
Other than that, it LGTM:
Acked-by: Arturo Borrero Gonzalez <arturo@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
