On 24 February 2018 at 23:07, Florian Westphal <fw@xxxxxxxxx> wrote: > Arturo Borrero Gonzalez <arturo@xxxxxxxxxxxxx> wrote: >> Concatenate all family/hook examples into a single one by means of includes. >> >> Put all example files under examples/. Use the '.nft' prefix and mark >> them as executable files. Use a static shebang declaration, since these >> are examples meant for final systems and users. >> >> While at it, refresh also the sets_and_maps.nft example file and also >> add the 'netdev-ingress.nft' example file. > > Looks good, two more nits: > > Any reason why this doesn't use > #! @sbindir@nft -f ? > I didn't expect we were using these files for development activities. My idea was to use just the static shebang for the purpose of being an example in final users systems (which would likely use /usr/sbin/nft). Also, this way the examples are readable & copy-ready for users in both the git repo and the tarball. (with static I mean: don't have it replaced by make). -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
