kbuild test robot <lkp@xxxxxxxxx> wrote: > Hi Florian, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on nf/master] > > url: https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-ipt_CLUSTERIP-two-more-fixes/20180219-090236 > base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__ > sparse warnings: (new ones prefixed by >>) > > >> include/linux/rculist.h:130:25: sparse: context imbalance in 'clusterip_tg_check' - unexpected unlock above is new > include/linux/rculist.h:130:25: sparse: context imbalance in 'clusterip_tg_destroy' - unexpected unlock above is old. Looks like false positive, both 'unexpected unlock' come from inlined clusterip_config_entry_put() which has: if (refcount_dec_and_lock(&c->entries, &cn->lock)) { ... list_del_rcu(&c->list); spin_unlock(&cn->lock); so sparse did not 'see' spin_lock(). -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
