Xin Long <lucien.xin@xxxxxxxxx> wrote: > Now it's doing cleanup_entry for oldinfo under the xt_table lock, > but it's not really necessary. After the replacement job is done > in xt_replace_table, oldinfo is not used elsewhere any more, and > it can be freed without xt_table lock safely. Right. > The important thing is that rtnl_lock is called in some xt_target > destroy, which means rtnl_lock, a big lock is used in xt_table > lock, a smaller one. It usually could be the reason why a dead > lock may happen. In which cases do we aquire the xt table mutex from places that hold rtnl mutex? > Besides, all xt_target/match checkentry is called out of xt_table > lock. It's better also to move all cleanup_entry calling out of > xt_table lock, just as do_replace_finish does for ebtables. Agree but I don't see how this patch fixes a bug so I would prefer if this could simmer in nf-next first. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
