> On Wed, Feb 14, 2018 at 08:16:52PM +0100, Pablo Neira Ayuso wrote: >> On Thu, Feb 15, 2018 at 12:34:31AM +0530, Shyam Saini wrote: >> > Hi Pablo, >> > >> > On Thu, Feb 15, 2018 at 12:02 AM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: >> > > Restore original syntax for the yet experimental VM low-level json >> > > representation. >> > > >> > > Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1224 >> > > Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> >> > > --- >> > > I asked for this change to make room for the high-level json >> > > representation, but we can use -j options for this instead. Given there >> > > are more users for the json representation that I expected, I'm fixing >> > > it myself by restoring the former behaviour. >> > >> > Why would one use "nft export" without "nft import". >> > if someone exports rules in json then they can't use those rules >> > given the fact that "nft import" was not available earlier. >> > >> > Am i missing something? >> >> With this patch nft import and nft export works as expected, ie. >> >> nft export ruleset json > file.json >> nft import ruleset json < file.json >> >> I'm just restoring 'nft export ruleset json' with this patch, it seems >> there are more users of this than I expected, so let's restore this >> before 0.8.3 is released, that's my proposal. > > Oh, probably you got confused because the patch title refers to nft > import when it should only refer to nft export ruleset json? No, I mean in some previous mail Phil mentioned that it could break user's script. I was thinking why one would use "nft export json" alone. Earlier we didn't have nft import command. So lets say if some user do "nft export json >file.json" then the rules in file.json are of no use without "nft import json" because we had no way to import or use them again. Sorry, I missed previous mail and couldn't follow up. Thanks! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
