Re: [PATCH nf-next] netfilter: remove messages print and boot/module load time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 19 Jan 2018, Pablo Neira Ayuso wrote:

> Several reasons for this:
> 
> * Several modules maintain internal version numbers, that they print at
>   boot/module load time, that are not exposed to userspace, as a
>   primitive mechanism to make revision number control from the earlier
>   days of Netfilter.
> 
> * IPset shows the protocol version at boot/module load time, instead
>   display this via module description, as Jozsef suggested.
> 
> * Remove copyright notice at boot/module load time in two spots, the
>   Netfilter codebase is a collective development effort, if we would
>   have to display copyrights for each contributor at boot/module load
>   time for each extensions we have, we would probably fill up logs with
>   lots of useless information - from a technical standpoint.
> 
> So let's be consistent and remove them all.
> 
> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> ---
>  net/netfilter/ipset/ip_set_core.c    | 3 ++-
>  net/netfilter/nf_conntrack_netlink.c | 5 -----
>  net/netfilter/nf_tables_api.c        | 1 -
>  net/netfilter/nfnetlink.c            | 4 ----
>  net/netfilter/nfnetlink_acct.c       | 2 --
>  net/netfilter/nft_compat.c           | 2 --
>  6 files changed, 2 insertions(+), 15 deletions(-)

Acked-by: Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>

Best regards,
Jozsef
-
E-mail  : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux