Re: [PATCH] netfilter: delete /proc THIS_MODULE references

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



	Hello,

On Sat, 13 Jan 2018, Alexey Dobriyan wrote:

> /proc has been ignoring struct file_operations::owner field for ages.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>

	IPVS part looks good to me.

Acked-by: Julian Anastasov <ja@xxxxxx>

> ---
> 
>  net/netfilter/ipvs/ip_vs_app.c          |    1 -
>  net/netfilter/ipvs/ip_vs_conn.c         |    2 --
>  net/netfilter/ipvs/ip_vs_ctl.c          |    3 ---
>  net/netfilter/nf_conntrack_expect.c     |    1 -
>  net/netfilter/nf_conntrack_standalone.c |    2 --
>  net/netfilter/nf_log.c                  |    1 -
>  net/netfilter/nf_synproxy_core.c        |    1 -
>  net/netfilter/nfnetlink_log.c           |    1 -
>  net/netfilter/nfnetlink_queue.c         |    1 -
>  net/netfilter/x_tables.c                |    3 ---
>  net/netfilter/xt_hashlimit.c            |    3 ---
>  11 files changed, 19 deletions(-)
> 
> --- a/net/netfilter/ipvs/ip_vs_app.c
> +++ b/net/netfilter/ipvs/ip_vs_app.c
> @@ -595,7 +595,6 @@ static int ip_vs_app_open(struct inode *inode, struct file *file)
>  }
>  
>  static const struct file_operations ip_vs_app_fops = {
> -	.owner	 = THIS_MODULE,
>  	.open	 = ip_vs_app_open,
>  	.read	 = seq_read,
>  	.llseek  = seq_lseek,
> --- a/net/netfilter/ipvs/ip_vs_conn.c
> +++ b/net/netfilter/ipvs/ip_vs_conn.c
> @@ -1143,7 +1143,6 @@ static int ip_vs_conn_open(struct inode *inode, struct file *file)
>  }
>  
>  static const struct file_operations ip_vs_conn_fops = {
> -	.owner	 = THIS_MODULE,
>  	.open    = ip_vs_conn_open,
>  	.read    = seq_read,
>  	.llseek  = seq_lseek,
> @@ -1221,7 +1220,6 @@ static int ip_vs_conn_sync_open(struct inode *inode, struct file *file)
>  }
>  
>  static const struct file_operations ip_vs_conn_sync_fops = {
> -	.owner	 = THIS_MODULE,
>  	.open    = ip_vs_conn_sync_open,
>  	.read    = seq_read,
>  	.llseek  = seq_lseek,
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -2116,7 +2116,6 @@ static int ip_vs_info_open(struct inode *inode, struct file *file)
>  }
>  
>  static const struct file_operations ip_vs_info_fops = {
> -	.owner	 = THIS_MODULE,
>  	.open    = ip_vs_info_open,
>  	.read    = seq_read,
>  	.llseek  = seq_lseek,
> @@ -2161,7 +2160,6 @@ static int ip_vs_stats_seq_open(struct inode *inode, struct file *file)
>  }
>  
>  static const struct file_operations ip_vs_stats_fops = {
> -	.owner = THIS_MODULE,
>  	.open = ip_vs_stats_seq_open,
>  	.read = seq_read,
>  	.llseek = seq_lseek,
> @@ -2230,7 +2228,6 @@ static int ip_vs_stats_percpu_seq_open(struct inode *inode, struct file *file)
>  }
>  
>  static const struct file_operations ip_vs_stats_percpu_fops = {
> -	.owner = THIS_MODULE,
>  	.open = ip_vs_stats_percpu_seq_open,
>  	.read = seq_read,
>  	.llseek = seq_lseek,

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux