On Fri, Dec 01, 2017 at 08:25:55PM +0100, Jozsef Kadlecsik wrote: > Hi Florian, > > On Thu, 30 Nov 2017, Florian Westphal wrote: > > > When sets are extremely large we can get softlockup during ipset -L. We > > could fix this by adding cond_resched_rcu() at the right location during > > iteration, but this only works if RCU nesting depth is 1. > > > > At this time entire variant->list() is called under under > > rcu_read_lock_bh. This used to be a read_lock_bh() but as rcu doesn't > > really lock anything, it does not appear to be needed, so remove it > > (ipset increments set reference count before this, so a set deletion > > should not be possible). > > Yes, the call of rcu_read_lock_bh() seems to be unnecessary, the > set->variant->list() functions protect the sensitive parts with > rcu_read_lock() anyway. Thanks! > > Acked-by: Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx> Also applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
