Hi Florian, On Thu, 30 Nov 2017, Florian Westphal wrote: > Check that we really hold nfnl mutex here instead of relying on correct > usage alone. > > Signed-off-by: Florian Westphal <fw@xxxxxxxxx> Yes, it's better this way :-) Acked-by: Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx> > --- > diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c > index d5a43cad90f04..1f3c03b3bebf2 100644 > --- a/net/netfilter/ipset/ip_set_core.c > +++ b/net/netfilter/ipset/ip_set_core.c > @@ -57,7 +57,7 @@ MODULE_ALIAS_NFNL_SUBSYS(NFNL_SUBSYS_IPSET); > > /* When the nfnl mutex is held: */ > #define ip_set_dereference(p) \ > - rcu_dereference_protected(p, 1) > + rcu_dereference_protected(p, lockdep_nfnl_is_held(NFNL_SUBSYS_IPSET)) > #define ip_set(inst, id) \ > ip_set_dereference((inst)->ip_set_list)[id] > > -- > 2.14.3 > > -- > To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
