On Fri, Nov 24, 2017 at 01:13:10PM +0100, Arturo Borrero Gonzalez wrote: > On 23 November 2017 at 15:23, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > According to bugzilla 1137: "flow tables" should not be syntactically > > unique. > > > > "Flow tables are always named, but they don't conform to the way sets, > > maps, and dictionaries work in terms of "add" and "delete" and all that. > > > > They are also "flow tables" instead of one word like "flows" or > > "throttle" or something. > > > > It seems weird to just have these break the syntactic expectations." > > > > Personally, I never liked the reference to "table" since we have very > > specific semantics in terms of what a "table" is netfilter for long > > time. > > > > This patch promotes "meter" as the new keyword. The former syntax is > > still accepted for a while, just to reduce chances of breaking things. > > At some point the former syntax will just be removed. > > > > Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1137 > > Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> > > > > I agree. Thanks, I just sent a few more patches to incrementally address what this is describing. > What about adding a warning in case of using the old syntax? > Something like: > > WARNING: this syntax is deprecated and will be deleted in the future, > use 'meter' instead. We can probably make a patch to add warnings on all things that we plan to deprecate. There are more things that we're just taking from the grammar to avoid sudden breakages, it would take a bit of time to review the existing grammar and spot them with a warning too. After that, make a new 0.8.1 release asap, including --with-mini-gmp fix if possible. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
