Hello Vasily,
On Mon, 6 Nov 2017, Vasily Averin wrote:
> Be sure that configs list initialized in net_init hook was return
> to initial state.
What is the goal of the patch series you sent in the third version in a
row?
- If the deinitializations are missing from the files, the patches
do not fix them, just emit warnings.
- If the deinitializations are not missing, the patches are totally
unnecessary.
It looks like debugging... but not expressed that way, neither in the
subject lines nor in the patch descriptions.
Best regards,
Jozsef
> Signed-off-by: Vasily Averin <vvs@xxxxxxxxxxxxx>
> ---
> net/ipv4/netfilter/ipt_CLUSTERIP.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c b/net/ipv4/netfilter/ipt_CLUSTERIP.c
> index 17b4ca5..4364a88 100644
> --- a/net/ipv4/netfilter/ipt_CLUSTERIP.c
> +++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c
> @@ -819,6 +819,9 @@ static void clusterip_net_exit(struct net *net)
> cn->procdir = NULL;
> #endif
> nf_unregister_net_hook(net, &cip_arp_ops);
> + WARN_ONCE(!list_empty(&cn->configs),
> + "net %x %s: configs list is not empty\n",
> + net->ns.inum, __func__);
> }
>
> static struct pernet_operations clusterip_net_ops = {
> --
> 2.7.4
>
>
-
E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
