Hi,
On Fri, Oct 20, 2017 at 02:12:02PM +0200, Pablo Neira Ayuso wrote:
> On Thu, Oct 19, 2017 at 10:18:42AM +0200, Phil Sutter wrote:
[...]
> > diff --git a/include/nftables/nftables.h b/include/nftables/nftables.h
> > new file mode 100644
> > index 0000000000000..052a77bfb5371
> > --- /dev/null
> > +++ b/include/nftables/nftables.h
>
> Is this nftables/nftables.h file what we will expose later on as
> header for this library?
Yes, exactly.
[...]
> > @@ -0,0 +1,88 @@
> > +/*
> > + * Copyright (c) 2017 Eric Leblond <eric@xxxxxxxxx>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + *
> > + */
> > +#ifndef LIB_NFTABLES_H
> > +#define LIB_NFTABLES_H
> > +
> > +struct parser_state;
> > +struct mnl_socket;
> > +
> > +struct nft_cache {
> > + bool initialized;
> > + struct list_head list;
> > + uint32_t seqnum;
> > +};
> > +
> > +#define INCLUDE_PATHS_MAX 16
> > +
> > +struct output_ctx {
> > + unsigned int numeric;
> > + unsigned int stateless;
> > + unsigned int ip2name;
> > + unsigned int handle;
> > + unsigned int echo;
> > + FILE *output_fp;
> > +};
>
> I think these structure should be just like:
>
> struct output_ctx;
>
> as a forward declaration. So we enforce users to use getters and
> setters.
Ultimately, I want to forward-declare struct nft_ctx as a whole. Is this
fine with you (also from advanced API point of view)?
Thanks, Phil
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
