On Thu, Oct 19, 2017 at 10:18:44AM +0200, Phil Sutter wrote: > This simplifies CLI code and allows to reduce libnftables API by not > exporting nft_run(). > > Since nft_run_cmd_from_buffer() takes care of scanner initialization and > libmnl socket passed to cli_init() is present as nft_ctx field as well, > signature of cli_init() can be reduced to just take nft_ctx pointer as > single argument. libmnl socket is indeed in nft_ctx, but we're planning a mode that allows to expose the mnl_socket for advanced handling. In that scenario, nft->nf_sock will be null. So I would prefer we don't do changes that we have to undo once the advanced API is in place. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html