Re: [PATCH] tests: xlate: print total no. of testfiles, tests and tests passed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 18, 2017 at 07:59:44PM +0530, Harsha Sharma wrote:
> Print errors and total no of tests and tests passed for testfile argument.
> Print total no. of testfiles, total no. of tests and total no. of tests
> passed for "all" argument.
> Change testfile argument to take "extensions/test_file" as argument.

Looks good, but general rule is:

        One logical change per patch.

I mean, this patch description says you're doing two things:

1) Print errors and total no of tests and tests passed for testfile
argument.

2) Change testfile argument to take "extensions/test_file" as
argument.

This means you have to send two patches, one for #1, and another one
for #2.

If you do so, git becomes way more useful when doing archeology, since
we know what patch added what single thing.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux