On Mon, Oct 9, 2017 at 5:32 PM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > On Sat, Oct 07, 2017 at 01:11:17PM +0530, Harsha Sharma wrote: >> On Fri, Oct 6, 2017 at 6:08 PM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: >> > On Thu, Oct 05, 2017 at 03:45:39PM +0530, Harsha Sharma wrote: >> >> Add testcases for creating named objects with unique name, defined >> >> by user and referencing them from rule. >> > >> > Also applied, thanks. >> > >> > Could you add another tests for 'limit' objects too? I think I posted >> > an example to the mailing list. >> >> Hello, >> I have pulled to latest tree, then make and make installed all changes >> but still I'm unable to add named 'limit' objects. If there is something that >> I'm missing, please let me know. > > Are you using a kernel compiled from nf.git tree? > >> Can you also please suggest some more tasks ? > > Yes. It would be great if you could update tests/py/nft-tests.py to > add a new option, basically to take all tests from files, place them > in a file and exercise the 'nft -f' path with such an autogenerated > large file with all tests. > > Would you have a look into that? > Hi, I have one doubt, nft-tests.py when executed without any argument or with option -d , already runs all commands in all test files ( don't directly run nft -f path as according to structure of tests in py, for lines starting with '*', table is added and similarly for ':', chain is added and similarly for objects, sets, etc.) so directly exercising 'nft -f' path on autogenerated file containing content of all tests files doesn't make sense. And calling function run_test_file for the large autogenerated file (as is called for each test file) will not make a lot of difference in result (compared to when executed without any argument) other than not printing total no. of test files executed and total no. of files passed. I hope I'm clear. Please correct me I'm wrong. What is exactly that I have to do in this task ? Thanks a lot for your time. Regards, Harsha Sharma > Thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
