Re: [PATCH] iptables: change large file support handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 04, 2017 at 04:52:05PM +0200, Juergen Borleis wrote:
> Hi Pablo,
> 
> On Wednesday 04 October 2017 16:46:06 Pablo Neira Ayuso wrote:
> > > > > The configure script handles the "--*-largefile" parameter badly.
> > > > > It defaults to large file support if not given and always disables
> > > > > largefile support if given (and it doesn't matter if 'enable' or
> > > > > 'disable' was used)
> > > >
> > > > It seems the default behaviour for a while has been to enable
> > > > largefile by default.
> > > >
> > > > Then, someone came in to add this --disable-largefile configure time
> > > > option, see:
> > > >
> > > > commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43
> > > > Author: Karl Hiramoto <karl@xxxxxxxxxxxx>
> > > > Date:   Mon May 10 17:50:41 2010 +0200
> > > >
> > > >     iptables: optionally disable largefile support
> > > >
> > > > So I would just fix --enable-* --disable-*.
> > > >
> > > > Would you follow up on this? Let me know, thanks.
> > >
> > > With my change the default is still "enabled" and you can disable it on
> > > demand.
> >
> > I'm going to remove this from your log message: "It defaults to large
> > file support if not given", when I read this I thought this was the
> > problem.
> 
> Ahh, okay.

Now applied, thanks for explaining.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux