Re: [Outreachy kernel] [PATCH 3/3] evaluate: make pointers in string arrays constant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 02, 2017 at 01:02:50PM +0530, Harsha Sharma wrote:
> static const char * array should probably be static const char * const
> array
> as per linux-kernel coding style
> 
> Signed-off-by: Harsha Sharma <harshasharmaiitr@xxxxxxxxx>
> ---
>  src/evaluate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/evaluate.c b/src/evaluate.c
> index b783054..f48801a 100644
> --- a/src/evaluate.c
> +++ b/src/evaluate.c
> @@ -33,7 +33,7 @@
>  static struct output_ctx octx_debug_dummy;
>  static int expr_evaluate(struct eval_ctx *ctx, struct expr **expr);
>  
> -static const char *byteorder_names[] = {
> +static const char * const byteorder_names[] = {

I can see more string array that could use this in the nftables tree.
Please, fix all in one single patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux