On 29 September 2017 at 13:39, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > Hi Arturo, > > On Mon, Sep 25, 2017 at 01:19:27PM +0200, Arturo Borrero Gonzalez wrote: >> diff --git a/ulogd.conf.in b/ulogd.conf.in >> index a987d64..fe54420 100644 >> --- a/ulogd.conf.in >> +++ b/ulogd.conf.in >> @@ -24,6 +24,16 @@ logfile="/var/log/ulogd.log" >> # 2. options for each plugin in seperate section below >> >> >> +# load all the plugins in one go. Then, there is no need to specify each >> +# plugin individually. There are two ways of using this clause, by leaving it >> +# blank (default) or by using a filesystem path. If blank a default directory >> +# configured at build time will be used (--with-ulogd2libdir). >> +# >> +# Examples: >> +# >> +# load_all_plugins= >> +# load_all_plugins=/usr/local/lib/ulogd/ >> + >> plugin="@pkglibdir@/ulogd_inppkt_NFLOG.so" >> #plugin="@pkglibdir@/ulogd_inppkt_ULOG.so" >> #plugin="@pkglibdir@/ulogd_inppkt_UNIXSOCK.so" > > Just an idea, probably better something like: > > plugin="@pkglibdir@/" > > I mean, if you specify a directory, then this means "include every > ulogd_*.so file there", it's easy to check via stat() if this is path > represents a directory, so you can skip string handling tricks. Ok, but how could we avoid putting there a complex, arch-dependant path? My first idea was to have the new config directive to don't accept any path and having the default set at build/configure time. For the sake of flexibility I added in the last moment the option for the user to give a path and override the one set at build/configure time. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
