On Fri, Sep 08, 2017 at 01:38:58AM -0400, Vishwanath Pai wrote: > 64bit division causes build/link errors on 32bit architectures. It > prints out error messages like: > > ERROR: "__aeabi_uldivmod" [net/netfilter/xt_hashlimit.ko] undefined! > > The value of avg passed through by userspace in BYTE mode cannot exceed > U32_MAX. Which means 64bit division in user2rate_bytes is unnecessary. > To fix this I have changed the type of param 'user' to u32. > > Since anything greater than U32_MAX is an invalid input we error out in > hashlimit_mt_check_common() when this is the case. > > Changes in v2: > Making return type as u32 would cause an overflow for small > values of 'user' (for example 2, 3 etc). To avoid this I bumped up > 'r' to u64 again as well as the return type. This is OK since the > variable that stores the result is u64. We still avoid 64bit > division here since 'user' is u32. Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
