Dao Quang Minh <dqminh89@xxxxxxxxx> wrote: > Thanks for the patch ! > > > rhlist removal however requires a rhlist walk. > We can have thousands of entries in such a list if source port/addresses > are reused for multiple flows, if this happens removal requests are so > expensive that deletions of a few thousand flows can take several > seconds(!). > > Do you think rhlist can use double linked list instead of single linked so > removal doesn't need to walk the whole chain ? Yes, but: > > I tried to add hlist_node to rhlist to speed up rhltable_remove but this > > isn't doable without changing semantics. rhltable_remove_fast will > > check that the to-be-deleted object is part of the table and that > > requires a list walk that we want to avoid. > > > > Furthermore, using hlist_node increases size of struct rhlist_head, which > > in turn increases nf_conn size. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
