2017-09-04 0:32 GMT+09:00 Jan Engelhardt <jengelh@xxxxxxx>: > > On Sunday 2017-09-03 16:30, Taehee Yoo wrote: > >>When xt_TEE target is inserted, lockdep warns about possible >>DEADLOCK situation. to avoid deadlock situation >>the register_netdevice_notifier() should be called by only init routine. >> >>+#include <linux/if.h> >> >> struct xt_tee_tginfo { >> union nf_inet_addr gw; >>- char oif[16]; >>+ char oif[IFNAMSIZ]; > > This should not be done, as xt_tee_tginfo is exported to userspace. > (It also has nothing to do with fixing the deadlock, really.) > >>+ case NETDEV_UNREGISTER: >>+ if ((dev->ifindex == priv->oif) && > > redundant new parenthesis group Thank you for your review! I will send v2 patch. Thanks -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html