Re: [PATH nft v2 15/18] libnftables: set max_errors to 1 in library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Aug 21, 2017 at 09:12:49PM +0200, Eric Leblond wrote:
> On Mon, 2017-08-21 at 10:37 +0200, Pablo Neira Ayuso wrote:
> > On Sat, Aug 19, 2017 at 05:24:17PM +0200, Eric Leblond wrote:
[...]
> > I remember you mentioned there's a problem with memory in the parser.
> > I would help to fix this, I'd appreciate if you can describe the
> > problem so we can address it here.
> 
> Here it my understanding: the max_errors system is causing the parser
> to continue instead of failing or finishing. As a result the internal
> memory releasing functions of bison are not called due to the
> intermediate state. At the end, in case of task with n errors, all 0
> ... n-1 state are left unfreed when the parsing is finished.

I'm currently trying to reproduce the issue by calling 'nft -f' with a
rule set file containing a number of errors, but somehow valgrind
doesn't show differences between max_errors of 1 and 10. Do you have a
test case or some instructions how to trigger the problem?

Thanks, Phil
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux