On Tue, Aug 15, 2017 at 01:27:56PM +0200, Phil Sutter wrote: > On Tue, Aug 15, 2017 at 12:35:30PM +0200, Pablo Neira Ayuso wrote: > > On Tue, Aug 15, 2017 at 01:43:04AM +0200, Phil Sutter wrote: > [...] > > > diff --git a/include/netlink.h b/include/netlink.h > > > index 3726171424c33..e7e4bbcfc0f51 100644 > > > --- a/include/netlink.h > > > +++ b/include/netlink.h > > > @@ -119,10 +119,7 @@ extern int netlink_add_rule_batch(struct netlink_ctx *ctx, > > > extern int netlink_del_rule_batch(struct netlink_ctx *ctx, > > > const struct handle *h, > > > const struct location *loc); > > > -extern int netlink_replace_rule_batch(struct netlink_ctx *ctx, > > > - const struct handle *h, > > > - const struct rule *rule, > > > - const struct location *loc); > > > +extern int netlink_replace_rule_batch(struct netlink_ctx *ctx, struct cmd *cmd); > > > > This patch comes with an interesting cleanup, that is that you just > > pass struct cmd as function parameter. > > > > Probably we can do this everywhere in the netlink.c code? I wonder if > > it's better just to fix this without changing the function footprint. > > Then, work a cleanup patch to update all netlink_* functions to pass > > struct cmd as parameter. > > > > So we leave everything looking consistent. > > This change was necessary in order to pass the required parameters to > cache_update(). Doing without, I would have to pass nf_sock, cache, obj > and msgs fields additionally, and the number of parameters was already > quite big. ENOCOFFEE: Actually I only use obj field of struct cmd, and that should be optional since I can also just use CMD_INVALID instead - so I'll drop the signature changes in v2. Thanks, Phil -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
