Re: [nft PATCH 1/4] mnl: Drop --echo support for non-batch calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 15, 2017 at 01:43:02AM +0200, Phil Sutter wrote:
> Echo support in nft_mnl_talk() was broken: nft_mnl_talk_cb() passed
> cbdata->data as second parameter to netlink_echo_callback() which
> expected it to be of type struct netlink_ctx while in fact it was
> whatever callers of nft_mnl_talk() passed as callback data (in most
> cases a NULL pointer).

Applied, thanks.

> I didn't notice this because I didn't test for kernels without support
> for transactions. This has been added to nftables in kernel version 3.16
> back in 2014. Since then, user space which doesn't support it can't even
> add a table anymore. So adding this new feature to the old code path is
> really not feasible, therefore drop this broken attempt at supporting
> it.

We fixed this problem with nft and 3.16 IIRC. So at least the very
basic featureset still available there works fine.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux