On Mon, Aug 14, 2017 at 01:54:39PM +0200, Phil Sutter wrote: > On Mon, Aug 14, 2017 at 01:43:22PM +0200, Pablo Neira Ayuso wrote: > > On Mon, Aug 14, 2017 at 01:36:44PM +0200, Phil Sutter wrote: > > > On Mon, Aug 14, 2017 at 11:26:51AM +0200, Pablo Neira Ayuso wrote: > > > > On Wed, Aug 09, 2017 at 01:16:40PM +0200, Phil Sutter wrote: > > > > > Long description of what it is and how it works in patch 3. Patch 1 is a > > > > > dependency to patch 2, Patch 3 adds a simple test suite which was > > > > > helpful during development. > > > > > > > > Applied, but please follow up asap to address a couple of issues: > > > > > > > > mnl.c: In function ‘nft_mnl_talk_cb’: > > > > mnl.c:82:5: warning: ‘rc’ may be used uninitialized in this function > > > > [-Wmaybe-uninitialized] > > > > if (rc) > > > > ^ > > > > > > Hmm, that's weird - the warning is correct, but gcc on my system doesn't > > > complain. Even after explicitly setting -Wmaybe-uninitialized. > > > > May be your gcc version. > > It's 6.3.0, but checking for uninitialized access is far from new so no > idea what is going on here. Ok, no problem, let's just fix this. [...] > > > > Why don't you simply pass the callback that you need to nft_mnl_recv() > > > > instead of adding this extra unnecesary abstraction... > > > > > > It is not unnecessary: There are several callers passing a callback to > > > nft_mnl_talk(). > > > > Then, you pass the callback that you need to nft_mnl_talk() as parameter. > > > > > I didn't want to mess with all of them but still insert > > > netlink_echo_callback(). Hence I introduced nft_mnl_talk_cb() which > > > takes care of the callback passed by callers and ultimately calls the > > > echo callback. > > > > Why don't you just add context as cb_data so you know you have to do > > the netlink_echo_callback() handling? > > > > There must be a better way to do this... > > Please disregard - I just noticed that in the only cases where echo > callback is required no custom callback is passed yet, so I can just get > by without any wrappers. Also, that code even doesn't work like this - > netlink_echo_callback() expects netlink_ctx as second parameter, which > is not the case. I'll get this sorted as well and then make sure it's > actually tested by manually disabling batch support in code. Great, wait for your patches, thanks Phil! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
