Re: [PATCH nf] netfilter: expect: add to hash table after expect init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 10, 2017 at 03:06:39PM +0200, Florian Westphal wrote:
> assuming we have lockless readers we should make sure they can only
> see expectations that have already been initialized.
> 
> hlist_add_head_rcu acts as memory barrier, move it after timer setup.
> 
> Theoretically we could crash due to a del_timer() on other cpu
> seeing garbage data.
> 
> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
> ---
>  Not seen in practice, however i think this race
>  is real.  Defer to nf-next if you think its not urgent.

Applied to nf-next, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux