Re: [nft PATCH v3 2/3] monitor: Fix printing of range elements in named sets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 19, 2017 at 07:17:36PM +0200, Pablo Neira Ayuso wrote:
> On Wed, Jul 19, 2017 at 03:05:28PM +0200, Phil Sutter wrote:
> > diff --git a/include/rule.h b/include/rule.h
> > index a25e99bdf4cfd..6acd5fa810ef5 100644
> > --- a/include/rule.h
> > +++ b/include/rule.h
> > @@ -217,6 +217,7 @@ extern struct rule *rule_lookup(const struct chain *chain, uint64_t handle);
> >   * @datalen:	mapping data len
> >   * @objtype:	mapping object type
> >   * @init:	initializer
> > + * @rg_cache:	cached range element (left)
> 
> Just a side note. This field is very much exclusive to event monitor
> printing, I would prefer this is cached somewhere else, away from the
> structure, if possible.

My solution was to make dummyset static and use it as a cache. Would
that be acceptible? I went with Arturo's solution since you seemed to
appreciate it and I didn't want to "steal" his credit. :)

Cheers, Phil
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux