On 12 July 2017 at 14:14, Phil Sutter <phil@xxxxxx> wrote:
> Usually one wants to at least initialize set_flags from the parent, so
> make allocation of a set's set expression more convenient.
>
> The idea to do this came when fixing an issue with output formatting of
> larger anonymous sets in nft monitor: Since
> netlink_events_cache_addset() didn't initialize set_flags,
> calculate_delim() didn't detect it's an anonymous set and therefore
> added newlines to the output.
>
> Reported-by: Arturo Borrero Gonzalez <arturo@xxxxxxxxxxxxx>
> Fixes: a9dc3ceabc10f ("expression: print sets and maps in pretty format")
> Signed-off-by: Phil Sutter <phil@xxxxxx>
> ---
> Changes since v1:
> - Changed set_expr_alloc() to return early if struct set pointer is
> NULL.
> - Removed the unrelated extra chunk.
> ---
> include/expression.h | 3 ++-
> src/evaluate.c | 2 +-
> src/expression.c | 12 ++++++++++--
> src/netlink.c | 8 +++-----
> src/parser_bison.y | 4 ++--
> src/rule.c | 2 +-
> 6 files changed, 19 insertions(+), 12 deletions(-)
>
Thanks Phil,
Acked-by: Arturo Borrero Gonzalez <arturo@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
