From: Pablo Neira Ayuso > Sent: 29 June 2017 23:53 > Should use ":=" instead of "+=". ... > diff --git a/net/netfilter/Makefile b/net/netfilter/Makefile > index c9b78e7b342f..913380919301 100644 > --- a/net/netfilter/Makefile > +++ b/net/netfilter/Makefile > @@ -70,10 +70,9 @@ obj-$(CONFIG_NETFILTER_SYNPROXY) += nf_synproxy_core.o > obj-$(CONFIG_NF_DUP_NETDEV) += nf_dup_netdev.o > > # nf_tables > -nf_tables-objs += nf_tables_core.o nf_tables_api.o nf_tables_trace.o > -nf_tables-objs += nft_immediate.o nft_cmp.o nft_range.o > -nf_tables-objs += nft_bitwise.o nft_byteorder.o nft_payload.o > -nf_tables-objs += nft_lookup.o nft_dynset.o > +nf_tables-objs := nf_tables_core.o nf_tables_api.o nf_tables_trace.o \ > + nft_immediate.o nft_cmp.o nft_range.o nft_bitwise.o \ > + nft_byteorder.o nft_payload.o nft_lookup.o nft_dynset.o Why? My preference is to add each file on its own line. Generates much less churn when files are added or removed. David -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
