Re: [PATCH 1/2] tests: shell: Add test for incomplete set add set command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 26, 2017 at 10:29 PM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Fri, Jun 23, 2017 at 05:35:55PM +0530, Shyam Saini wrote:
>> Before the [Test] commit if we run nft with incomplete "add set"
>> command it caused segmentation fault and exit with error code 139 and
>> further it didn't throw any error message.
>>
>>   For example:
>>     $ sudo nft add set t s
>>
>> But after the [Test] commit it throws syntax error message and exits with
>> return value 1.
>>
>>   For example:
>>     $ sudo nft add set t s
>>     <cmdline>:1:12-12: Error: syntax error, unexpected newline, expecting '{'
>>     add set t s
>>                ^
>>
>> This commit tests changes made in the [Test] commit.
>
> Applied, thanks.
>
> I have reworked a bit your commit message, it looks a bit convoluted.

Thanks a lot :)

> No worries, have a look at what I pushed out for reference.

Shouldn't we follow conventions mentioned in "scripts/checkpatch.pl" ?

Thanks,
shyam
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux