2017-06-20 3:04 GMT+09:00 Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>:
> On Tue, Jun 06, 2017 at 12:21:25AM +0900, Taehee Yoo wrote:
>> diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
>> index 8a0f218..bb27e99 100644
>> --- a/net/netfilter/nfnetlink_queue.c
>> +++ b/net/netfilter/nfnetlink_queue.c
>> @@ -928,7 +928,6 @@ static unsigned int nfqnl_nf_hook_drop(struct net *net)
>> unsigned int instances = 0;
>> int i;
>>
>> - rcu_read_lock();
>> for (i = 0; i < INSTANCE_BUCKETS; i++) {
>> struct nfqnl_instance *inst;
>> struct hlist_head *head = &q->instance_table[i];
>> @@ -938,7 +937,6 @@ static unsigned int nfqnl_nf_hook_drop(struct net *net)
>> instances++;
>> }
>> }
>> - rcu_read_unlock();
>>
>> return instances;
>> }
>
> This is called from nfqnl_rcv_dev_event(), are you sure we can get rid
> of this rcu read lock ?
I'm sorry, I couldn't find code that nfqnl_rcv_dev_event() calls
nfqnl_nf_hook_drop().
Could you please tell me where I can find that code?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
