On Fri, Jun 16, 2017 at 10:34:11PM +0200, Florian Westphal wrote:
> diff --git a/src/evaluate.c b/src/evaluate.c
> index 311c86c5abe9..4cbbd5f9b52a 100644
> --- a/src/evaluate.c
> +++ b/src/evaluate.c
> @@ -1691,6 +1691,18 @@ static int expr_evaluate_fib(struct eval_ctx *ctx, struct expr **exprp)
> return expr_evaluate_primary(ctx, exprp);
> }
>
> +static int expr_evaluate_meta(struct eval_ctx *ctx, struct expr **exprp)
> +{
> + struct expr *meta = *exprp;
> +
> + if (ctx->pctx.family != NFPROTO_INET &&
> + meta->flags & EXPR_F_PROTOCOL &&
> + meta->meta.key == NFT_META_NFPROTO)
> + return expr_error(ctx->msgs, meta,
> + "meta nfproto is only useful in the inet family");
Nitpick: Before you push this one, you probably want to mangle this
line to get it aligned with expr_error().
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
