On Thu, Jun 15, 2017 at 3:21 PM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > On Fri, Jun 09, 2017 at 09:31:00PM +0530, Shyam Saini wrote: >> This test checks bug identified and fixed in the commit mentioned below >> In a statement if there are multiple src data then it would be >> totally ambiguous to decide which value to set. >> >> We don't add this test in python testsuite, because there we only have >> "ok" and "fail" as return code. So, we can't detect 134 != 1 there. >> (both 1 and 134 stats failure) > > OK I see, so 134 and 1 refers to the exit code we return to the shell > (or whoever runs nft). > > Could you have a look at tests/py/nft-test.py > Sure > If the problem is just the exit code, then I suggest you add these > tests to the python infrastructure, then make sure that the python > script checks for 1 for 'fail'. > > Could you have a look, please? I'll send the python version of this test. Thanks, shyam -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
