Re: [PATCH V2] netfilter: Remove duplicated rcu_read_lock.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



	Hello,

On Tue, 6 Jun 2017, Taehee Yoo wrote:

> Some functions are called by nf_hook() and these
> functions hold rcu_read_lock() But nf_hook() already holds
> rcu_read_lock() therefore callee's rcu_read_lock() are useless.

...

> Signed-off-by: Taehee Yoo <ap420073@xxxxxxxxx>

	IPVS part looks ok to me,

Acked-by: Julian Anastasov <ja@xxxxxx>

> ---
> 
> V2:
>    - Remove comments.
>    - The rcu_read_lock under below functions are removed.
>     - {tcp, udp, sctp}_app_conn_bind,
>     - ip_vs_bypass_xmit,
>     - ip_vs_bypass_xmit_v6,
>     - ip_vs_nat_xmit,
>     - ip_vs_nat_xmit_v6,
>     - ip_vs_tunnel_xmit,
>     - ip_vs_tunnel_xmit_v6
>     - ip_vs_dr_xmit,
>     - ip_vs_dr_xmit_v6
>     - destroy_conntrack,
>     - __ctnetlink_glue_build,
>     - ctnetlink_expect_event,
>     - ctnetlink_proto_size,
>     - ctnetlink_conntrack_event,
>     - nfqnl_nf_hook_drop,
>     - tproxy_laddr6.
> 
> V1:
>    - Initial version

...

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux