Re: [PATCH conntrack-tools] ipv6: remove use of HAVE_INET_PTON_IPV6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 29/05/2017 à 18:25, Pablo Neira Ayuso a écrit :
[snip]
>> -#ifdef HAVE_INET_PTON_IPV6
>> -	if (inet_pton(AF_INET6, $2,
>> -		      &conf.channel[conf.channel_num].u.mcast.in) <= 0) {
>> +	err = inet_pton(AF_INET6, $2,
>> +			&conf.channel[conf.channel_num].u.mcast.in);
>> +	if (err == 0) {
>>  		dlog(LOG_WARNING, "%s is not a valid IPv6 address", $2);
>>  		break;
>> +	} else if (err < 0) {
>> +		dlog(LOG_WARNING, "inet_pton(): IPv6 unsupported!");
>> +		break;
> 
> Probably better to exit() here and to use LOG_ERR instead?
Sure, I kept the previous behavior, but indeed, it's better to exit. I will send
a new version.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux