Liping Zhang <zlpnobody@xxxxxxx> wrote: > From: Liping Zhang <zlpnobody@xxxxxxxxx> > > We need to clear the IPS_SRC_NAT_DONE_BIT to indicate that the ct has > been removed from nat_bysource table. But unfortunately, we use the > non-atomic bit operation: "ct->status &= ~IPS_NAT_DONE_MASK". So > there's a race condition that we may clear the _DYING_BIT set by > another CPU unexpectedly. > > Since we don't care about the IPS_DST_NAT_DONE_BIT, so just using > clear_bit to clear the IPS_SRC_NAT_DONE_BIT is enough. > > Also note, this is the last user which use the non-atomic bit operation > to update the confirmed ct->status. Looks good, thanks Liping. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
