Re: [PATCH] extensions: libxt_hashlimit: fix 64-bit printf format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 18, 2017 at 03:37:30PM +0200, Pablo Neira Ayuso wrote:
> On Thu, May 18, 2017 at 01:43:28PM +0200, Alin Nastac wrote:
> > Furthermore, this extension use a mix of PRIu64 and %llu formats for
> > uint64_t values. IMO it should use only one, for the sake of consistency.
> > 
> > Signed-off-by: Alin Nastac <alin.nastac@xxxxxxxxx>
> > ---
> >  extensions/libxt_hashlimit.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/extensions/libxt_hashlimit.c b/extensions/libxt_hashlimit.c
> > index 9e63e1e..21b7aaa 100644
> > --- a/extensions/libxt_hashlimit.c
> > +++ b/extensions/libxt_hashlimit.c
> > @@ -942,7 +942,7 @@ static void print_packets_rate_xlate(struct xt_xlate *xl, uint64_t avg,
> >  		    _rates[i].mult / avg < _rates[i].mult % avg)
> >  			break;
> >  
> > -	xt_xlate_add(xl, " %llu/%s burst %lu packets",
> > +	xt_xlate_add(xl, " %llu/%s burst "PRIu64" packets",
>                                          ^
>                                        missing % here?

OK, please revamp, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux