Re: [PATCH ulogd2 1/2] ulogd.conf: harmonize log file options with module default values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Wed, 2017-04-12 at 14:40 +0300, Kaarle Ritvanen wrote:
> On Tue, 7 Mar 2017, Eric Leblond wrote:
> 
> > I really like the idea of getting an harmonized naming for the log
> > files but I think we should do it reverse for values that are not
> > commented in the configuration file. Most distributions and install
> > are
> > shipping with a copy of default configuration. 
> > 
> > Most users won't have changed the values that are uncommented. So
> > they
> > will have on disk the log file with name defined in the
> > configuration
> > file. And they will benefit from a new logrotate file. Thus we
> > should
> > use the file name defined in the conf as value of the default file
> > name
> > in code.
> > 
> > Could you resubmit a patchset ?
> 
> I preprared a new patch set according to your feedback:
> 
> http://marc.info/?l=netfilter-devel&m=149064027208491&w=2
> http://marc.info/?l=netfilter-devel&m=149064028308496&w=2
> 
> Please take a look at them.

No excuse on me to have missed that. Really sorry. I've just pushed
that to git.

Best regards,
-- 
Eric Leblond <eric@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux