Re: [PATCH nft] netlink_delinearize: don't kill dependencies accross statements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Mon, May 08, 2017 at 10:17:50AM +0200, Florian Westphal wrote:
> > nft currently translates
> > ip protocol tcp meta mark set 1 tcp dport 22
> > to
> > mark set 0x00000001 tcp dport 22
> > 
> > This is wrong, the latter form is same as
> > 
> > mark set 0x00000001 ip protocol tcp tcp dport 22
> > 
> > and thats not correct (original rule sets mark for tcp packets only).
> > 
> > We need to clear the dependency stack whenever we see a statement other
> > than stmt_expr, as these will have side effects (counter, payload
> > mangling, logging and the like).
> > 
> > Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
> 
> Acked-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> Could you add a test for this? Thanks.

Yes, I'll push that too soon, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux