On 25 April 2017 at 13:34, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Thu, Apr 20, 2017 at 07:28:06PM +0200, Arturo Borrero Gonzalez wrote:
>> These warnings, if they happen, should help users.
>>
>> Signed-off-by: Arturo Borrero Gonzalez <arturo@xxxxxxxxxx>
>> ---
>> src/channel.c | 6 +++++-
>> src/queue_tx.c | 11 +++++++++--
>> 2 files changed, 14 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/channel.c b/src/channel.c
>> index acbfa7d..b2f114d 100644
>> --- a/src/channel.c
>> +++ b/src/channel.c
>> @@ -19,6 +19,7 @@
>> #include "channel.h"
>> #include "network.h"
>> #include "queue.h"
>> +#include "log.h"
>>
>> static struct channel_ops *ops[CHANNEL_MAX];
>> extern struct channel_ops channel_mcast;
>> @@ -161,8 +162,11 @@ static void channel_enqueue_errors(struct channel *c)
>> struct channel_error *error;
>>
>> qobj = queue_object_new(Q_ELEM_ERR, sizeof(struct channel_error));
>> - if (qobj == NULL)
>> + if (qobj == NULL) {
>> + dlog(LOG_WARNING, "could not enqueue channel errors, failed to"
>> + " allocate memory");
>
> Did you ever hit this?
>
I don't know, no way to know in a production system since this happen silently.
Since conntrackd can be of critical importance in some environments I
guess it doesn't harm
to be more verbose. This concrete memory allocation failure isn't
interesting per se, but it could be related
to other more serious issues on the system.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
