On Fri, Apr 14, 2017 at 01:56:21PM +0200, Vincent Bernat wrote: > When an unknown option is given, iptables-restore should exit instead of > continue its operation. For example, if `--table` was misspelled, this > could lead to an unwanted change. Moreover, exit with a status code of > 1. Make the same change for iptables-save. > > OTOH, exit with a status code of 0 when requesting help. Hm, this doesn't apply cleanly to iptables.git for some reason. $ git am /var/tmp/iptables-v2-iptables-restore-save-exit-when-given-an-unknown-option.patch Applying: iptables-restore/save: exit when given an unknown option error: patch failed: iptables/ip6tables-restore.c:46 error: iptables/ip6tables-restore.c: patch does not apply error: patch failed: iptables/iptables-restore.c:43 error: iptables/iptables-restore.c: patch does not apply Patch failed at 0001 iptables-restore/save: exit when given an unknown option The copy of the patch that failed is found in: /home/devel/iptables/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Would you refresh your tree and resubmit? Thanks! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
