Re: [PATCH nf v2] net/openvswitch: Delete conntrack entry clashing with an expectation.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Apr 13, 2017, at 21:18, Liping Zhang <zlpnobody@xxxxxxxxx> wrote:
> 
> Hi Jarno,
> 
> 2017-04-14 7:05 GMT+08:00 Jarno Rajahalme <jarno@xxxxxxx>:
> [...]
>> +               h = nf_conntrack_find_get(net, zone, &tuple);
>> +               if (h) {
>> +                       struct nf_conn *ct = nf_ct_tuplehash_to_ctrack(h);
>> +
>> +                       if (nf_ct_is_confirmed(ct))
> 
> If the _ct_ could be got by nf_conntrack_find_get(),  it means that
> the _ct_ have
> been confirmed already, so the judgement "if (nf_ct_is_confirmed(ct))" seems
> unnecessary.
> 

You are right, thanks for pointing this out! Will send v3 later today,

  Jarno

>> +                               nf_ct_delete(ct, 0, 0);
>> +                       nf_conntrack_put(&ct->ct_general);
>> +               }
>> +       }

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux