On Mon, Apr 10, 2017 at 05:59:07PM +0200, Jan Engelhardt wrote: > > On Saturday 2017-04-08 22:29, Pablo Neira Ayuso wrote: > >> @@ -262,7 +262,7 @@ static uint64_t parse_burst(const char *burst, int revision) > >> if (v > max) > >> xtables_error(PARAMETER_PROBLEM, "bad value for option " > >> "\"--hashlimit-burst\", value \"%s\" too large " > >> - "(max %lumb).", burst, max/1024/1024); > >> + "(max %" PRIu64 "mb).", burst, max/1024/1024); > > ^ ^ > > > >I can remove this whitespaces, right? > > With my distro hat on: > > Clumping these together like "foo"BAR"baz" has already caused compile failures > in the broader scope of distributions (thousands of packages) because languages > introduced new tokenization rules. Admittedly, this occurred in C++ (namely, > user-defined string literals), but it does show that tokens which logically are > separate should stay separate. Existing code doesn't add space, so I would like we don't introduce inconsistencies. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
