Thank you for your review! 2017-04-07 4:51 GMT+09:00 Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>: > On Tue, Mar 28, 2017 at 12:28:50AM +0900, Taehee Yoo wrote: >> __nf_nat_decode_session is called from nf_nat_decode_session as decodefn. >> before calling decodefn, it already set rcu_read_lock. so rcu_read_lock in >> __nf_nat_decode_session can be removed. > > Could you have close look at the tree to confirm if we have more spots > where rcu_read_lock is unnecessary? > > $ git grep rcu_read_lock net/netfilter/ | wc -l > 158 > $ git grep rcu_read_lock > net/ipv4/netfilter/ | wc -l > 3 > $ git grep rcu_read_lock > net/ipv6/netfilter/ | wc -l > 2 > $ git grep rcu_read_lock > net/bridge/netfilter/ | wc -l > > It's a fair good amount, it would take me around one hour probably to > evaluate those here. > > If you can help us on verifying this, it would be simply great. > > Thanks! okay, I confirm whole rcu_read_lock then I will resend a single patch as soon as possible. may be it needs a week. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
