Re: [PATCH nf-next v2 1/1] netfilter: nat: Correct the return value check for nat mangled packet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 27, 2017 at 11:12:08PM +0800, gfree.wind@xxxxxxxxxxx wrote:
> From: Gao Feng <fgao@xxxxxxxxxx>
> 
> The return value type of function nf_nat_mangle_tcp/udp_packet is
> int, but actually it is used as bool type. And most codes follow
> this rule, for example, the sip, h323, and ftp. But some codes treat
> the return value as NF_ACCEPT and NF_DROP, like amanda and irc.
> 
> Now use the bool type instead of the int to make it clear.

One spot still not converted.

I'm going to collapse this patch to yours. Please review so you don't
have to send a v3.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux