Hi All, > -----Original Message----- > From: gfree.wind@xxxxxxxxxxx [mailto:gfree.wind@xxxxxxxxxxx] > Sent: Thursday, April 6, 2017 7:05 PM > To: pablo@xxxxxxxxxxxxx; netfilter-devel@xxxxxxxxxxxxxxx > Cc: Gao Feng <fgao@xxxxxxxxxx> > Subject: [PATCH nf 1/1] netfilter: xt_CT: Fix one possible memleak of timeout > > From: Gao Feng <fgao@xxxxxxxxxx> > > When nf_ct_timeout_ext_add failed in xt_ct_set_timeout, it should free the > timeout refcnt. > > Now goto the err_put_timeout error handler instead of going ahead. > > Signed-off-by: Gao Feng <fgao@xxxxxxxxxx> > --- > net/netfilter/xt_CT.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/netfilter/xt_CT.c b/net/netfilter/xt_CT.c index > b008db0..3cd812c 100644 > --- a/net/netfilter/xt_CT.c > +++ b/net/netfilter/xt_CT.c > @@ -168,7 +168,7 @@ static void __xt_ct_tg_timeout_put(struct ctnl_timeout > *timeout) > } > timeout_ext = nf_ct_timeout_ext_add(ct, timeout, GFP_ATOMIC); > if (timeout_ext == NULL) > - ret = -ENOMEM; > + goto err_put_timeout; > > rcu_read_unlock(); > return ret; > -- > 1.9.1 > Sorry, please ignore this patch. I have sent the v2 patch which keep the -ENOMEM assignment. Regards Feng -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
