Re: [PATCH 0/3] ebtables: Constify option struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 28, 2017 at 04:57:48PM +0530, Gargi Sharma wrote:
> The struct option is generally used only to initialise
> fields inside certain structs and is not modified anywhere.
> Done using Coccinelle:
> 
> @r1 disable optional_qualifier@
> identifier s,i;
> position p;
> @@
> 
> static struct option i@p[] ={...};
> 
> @ok1@
> identifier r1.i;
> expression e;
> position p;
> @@
> e = i@p
> 
> @bad@
> position p != {r1.p,ok1.p};
> identifier r1.i;
> @@
> e@i@p
> 
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> static
> +const
> struct option i[] = { ... };
> 
> Gargi Sharma (3):
>   ebtables: extensions: Constify option struct
>   ebtables: extensions: Constify option struct
>   ebtables: extensions: Constify option struct

Please, collapse this patches in one single.

They are part of the same logical update and...

>  extensions/ebt_802_3.c    | 2 +-
>  extensions/ebt_among.c    | 2 +-
>  extensions/ebt_arp.c      | 2 +-
>  extensions/ebt_arpreply.c | 2 +-
>  extensions/ebt_inat.c     | 4 ++--
>  extensions/ebt_ip.c       | 2 +-
>  extensions/ebt_limit.c    | 2 +-
>  extensions/ebt_log.c      | 2 +-
>  extensions/ebt_mark.c     | 2 +-
>  extensions/ebt_mark_m.c   | 2 +-
>  extensions/ebt_nat.c      | 4 ++--
>  extensions/ebt_nflog.c    | 2 +-
>  extensions/ebt_pkttype.c  | 2 +-
>  extensions/ebt_redirect.c | 2 +-
>  extensions/ebt_standard.c | 2 +-
>  extensions/ebt_stp.c      | 2 +-
>  extensions/ebt_ulog.c     | 2 +-
>  extensions/ebt_vlan.c     | 2 +-
>  18 files changed, 20 insertions(+), 20 deletions(-)

diffstat shows this update is rather small.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux