> -----Original Message----- > From: netfilter-devel-owner@xxxxxxxxxxxxxxx > [mailto:netfilter-devel-owner@xxxxxxxxxxxxxxx] On Behalf Of Pablo Neira Ayuso > Sent: Monday, March 27, 2017 8:25 PM > To: fgao@xxxxxxxxxx > Cc: netfilter-devel@xxxxxxxxxxxxxxx; gfree.wind@xxxxxxxxx > Subject: Re: [PATCH nf-next 1/1] netfilter: Use bool type instead of int as the > return value of nf_conntrack_tuple_taken and nf_nat_used_tuple > > On Tue, Mar 07, 2017 at 12:28:55PM +0800, fgao@xxxxxxxxxx wrote: > > From: Gao Feng <fgao@xxxxxxxxxx> > > > > These two functions return 1/0 as true or false, so it could use bool > > type directly instead of int. > > Too long patch subject. Ok, I would make it shorter. > > > Signed-off-by: Gao Feng <fgao@xxxxxxxxxx> > > --- > > include/net/netfilter/nf_conntrack.h | 2 +- > > include/net/netfilter/nf_nat.h | 2 +- > > net/netfilter/nf_conntrack_core.c | 6 +++--- > > net/netfilter/nf_nat_core.c | 2 +- > > 4 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/include/net/netfilter/nf_conntrack.h > > b/include/net/netfilter/nf_conntrack.h > > index f540f9a..32a0394 100644 > > --- a/include/net/netfilter/nf_conntrack.h > > +++ b/include/net/netfilter/nf_conntrack.h > > @@ -160,7 +160,7 @@ void nf_conntrack_alter_reply(struct nf_conn *ct, > > > > /* Is this tuple taken? (ignoring any belonging to the given > > conntrack). */ > > -int nf_conntrack_tuple_taken(const struct nf_conntrack_tuple *tuple, > > +bool nf_conntrack_tuple_taken(const struct nf_conntrack_tuple *tuple, > > const struct nf_conn *ignored_conntrack); > > Did you audit callers if they handle this type change accordingly? I don't see > any description about this on your patch. I will add the caller description in the update patch. Regards Feng > -- > To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the > body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at > http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
